From 195d4be086a0f83fcad61fcd08963e30ce270e0d Mon Sep 17 00:00:00 2001
From: Ivan Fontosh <ifontosh@it-aces.com>
Date: Wed, 15 Jul 2026 19:04:02 +0800
Subject: [PATCH] fix(editor): polish project picker and scene description UX

Validate unique campaign names, add search, flip menus at scroll end, drop TipTap links, and scroll long description previews.

Co-authored-by: Cursor <cursoragent@cursor.com>
---
 app/renderer/editor/EditorApp.module.css      | 15 ++++++-
 app/renderer/editor/EditorApp.tsx             | 45 ++++++++++++++++---
 app/renderer/editor/SceneDescriptionModal.tsx | 29 +-----------
 app/renderer/editor/i18n/editorMessages.ts    |  4 ++
 4 files changed, 56 insertions(+), 37 deletions(-)

diff --git a/app/renderer/editor/EditorApp.module.css b/app/renderer/editor/EditorApp.module.css
index d79f982..3ea4615 100644
--- a/app/renderer/editor/EditorApp.module.css
+++ b/app/renderer/editor/EditorApp.module.css
@@ -259,6 +259,17 @@
   font: inherit;
 }
 
+.fileMenuItemDanger {
+  text-align: left;
+  padding: 10px;
+  border-radius: var(--radius-sm);
+  border: none;
+  background: transparent;
+  color: var(--color-danger);
+  cursor: pointer;
+  font: inherit;
+}
+
 .fileMenuSubHost {
   position: relative;
 }
@@ -688,7 +699,8 @@
 
 .descriptionPreview {
   max-height: 4.6em;
-  overflow: hidden;
+  overflow-x: hidden;
+  overflow-y: auto;
   padding: 8px 10px;
   border-radius: var(--radius-md);
   border: 1px solid var(--stroke);
@@ -697,7 +709,6 @@
   font-size: var(--text-xs);
   line-height: 1.45;
   word-break: break-word;
-  pointer-events: none;
 }
 
 .descriptionPreview :global(p),
diff --git a/app/renderer/editor/EditorApp.tsx b/app/renderer/editor/EditorApp.tsx
index ff43266..4e19d37 100644
--- a/app/renderer/editor/EditorApp.tsx
+++ b/app/renderer/editor/EditorApp.tsx
@@ -1893,11 +1893,13 @@ function ProjectPicker({
 }: ProjectPickerProps) {
   const { t, locale } = useEditorI18n();
   const [name, setName] = useState(() => t('picker.defaultName'));
+  const [projectQuery, setProjectQuery] = useState('');
   const [rowMenuFor, setRowMenuFor] = useState<ProjectId | null>(null);
   const [rowMenuPos, setRowMenuPos] = useState<{ left: number; top: number } | null>(null);
   const [pendingDelete, setPendingDelete] = useState<{ id: ProjectId; name: string } | null>(null);
   const [deleteSubmitting, setDeleteSubmitting] = useState(false);
   const [deleteError, setDeleteError] = useState<string | null>(null);
+  const projectListScrollRef = useRef<HTMLDivElement | null>(null);
 
   useEffect(() => {
     if (!rowMenuFor) return;
@@ -1912,24 +1914,41 @@ function ProjectPicker({
     return () => window.removeEventListener('mousedown', onDown);
   }, [rowMenuFor]);
 
+  const trimmedName = name.trim();
+  const nameOk = trimmedName.length >= 3;
+  const nameDup = projects.some((p) => normalizeName(p.name) === normalizeName(trimmedName));
+  const canCreate = licenseActive && nameOk && !nameDup;
+
+  const filteredProjects = useMemo(() => {
+    const q = projectQuery.trim().toLowerCase();
+    if (!q) return projects;
+    return projects.filter((p) => p.name.toLowerCase().includes(q));
+  }, [projectQuery, projects]);
+
   return (
     <div className={styles.projectPicker}>
       <div className={styles.projectPickerTitle}>{t('picker.title')}</div>
       <div className={styles.projectPickerForm}>
         <Input value={name} onChange={setName} placeholder={t('picker.newPlaceholder')} />
+        {!nameOk ? <div className={styles.fieldError}>{t('rename.projectMin')}</div> : null}
+        {nameOk && nameDup ? <div className={styles.fieldError}>{t('rename.projectDup')}</div> : null}
         <Button
           variant="primary"
-          disabled={!licenseActive}
+          disabled={!canCreate}
           title={!licenseActive ? t('top.afterLicense') : undefined}
           onClick={() => {
-            if (!licenseActive) return;
-            void onCreate(name);
+            if (!canCreate) return;
+            void onCreate(trimmedName);
           }}
         >
           {t('picker.create')}
         </Button>
       </div>
       <div className={styles.spacer6} />
+      <div className={styles.gridTools}>
+        <Input value={projectQuery} onChange={setProjectQuery} placeholder={t('picker.search')} />
+      </div>
+      <div className={styles.spacer6} />
       <div className={styles.sectionLabel}>{t('picker.existing')}</div>
       {!licenseActive && projects.length > 0 ? (
         <>
@@ -1937,9 +1956,9 @@ function ProjectPicker({
           <div className={styles.spacer6} />
         </>
       ) : null}
-      <div className={styles.projectListScroll}>
+      <div className={styles.projectListScroll} ref={projectListScrollRef}>
         <div className={styles.projectList}>
-          {projects.map((p) => {
+          {filteredProjects.map((p) => {
             const isOpening = openingProjectId === p.id;
             const openDisabled = !licenseActive || openingProjectId !== null;
             return (
@@ -2000,8 +2019,17 @@ function ProjectPicker({
                     if (!licenseActive || openingProjectId !== null) return;
                     const r = e.currentTarget.getBoundingClientRect();
                     const menuW = 220;
+                    const menuH = 96;
+                    const gap = 8;
                     const left = Math.max(8, Math.min(r.right - menuW, window.innerWidth - menuW - 8));
-                    setRowMenuPos({ left, top: r.bottom + 8 });
+                    const scrollEl = projectListScrollRef.current;
+                    const scrollAtEnd =
+                      !!scrollEl &&
+                      scrollEl.scrollHeight > scrollEl.clientHeight &&
+                      scrollEl.scrollTop + scrollEl.clientHeight >= scrollEl.scrollHeight - 2;
+                    const openUp = scrollAtEnd || r.bottom + gap + menuH > window.innerHeight - 8;
+                    const top = openUp ? Math.max(8, r.top - menuH - gap) : r.bottom + gap;
+                    setRowMenuPos({ left, top });
                     setRowMenuFor((cur) => (cur === p.id ? null : p.id));
                   }}
                 >
@@ -2011,6 +2039,9 @@ function ProjectPicker({
             );
           })}
           {projects.length === 0 ? <div className={styles.muted}>{t('picker.empty')}</div> : null}
+          {projects.length > 0 && filteredProjects.length === 0 ? (
+            <div className={styles.muted}>{t('picker.searchEmpty')}</div>
+          ) : null}
         </div>
       </div>
       {rowMenuFor && rowMenuPos
@@ -2038,7 +2069,7 @@ function ProjectPicker({
               <button
                 type="button"
                 role="menuitem"
-                className={styles.fileMenuItem}
+                className={styles.fileMenuItemDanger}
                 onClick={() => {
                   const id = rowMenuFor;
                   const proj = projects.find((x) => x.id === id);
diff --git a/app/renderer/editor/SceneDescriptionModal.tsx b/app/renderer/editor/SceneDescriptionModal.tsx
index bd0cb7b..f3a7926 100644
--- a/app/renderer/editor/SceneDescriptionModal.tsx
+++ b/app/renderer/editor/SceneDescriptionModal.tsx
@@ -61,14 +61,7 @@ export function SceneDescriptionModal({ initialHtml, onClose, onSave }: SceneDes
       StarterKit.configure({
         heading: { levels: [2, 3] },
         codeBlock: false,
-        link: {
-          openOnClick: false,
-          autolink: true,
-          HTMLAttributes: {
-            rel: 'noopener noreferrer',
-            target: '_blank',
-          },
-        },
+        link: false,
       }),
       Placeholder.configure({
         placeholder: t('scene.descriptionPlaceholder'),
@@ -109,7 +102,6 @@ export function SceneDescriptionModal({ initialHtml, onClose, onSave }: SceneDes
       h2: ed.isActive('heading', { level: 2 }),
       h3: ed.isActive('heading', { level: 3 }),
       blockquote: ed.isActive('blockquote'),
-      canLink: ed.isEditable,
     }),
   });
 
@@ -117,18 +109,6 @@ export function SceneDescriptionModal({ initialHtml, onClose, onSave }: SceneDes
     onSave(normalizeSceneDescriptionHtml(editor.getHTML()));
   };
 
-  const setLink = () => {
-    const prev = editor.getAttributes('link').href as string | undefined;
-    const next = window.prompt(t('scene.descriptionLinkPrompt'), prev ?? 'https://');
-    if (next === null) return;
-    const trimmed = next.trim();
-    if (trimmed === '') {
-      editor.chain().focus().extendMarkRange('link').unsetLink().run();
-      return;
-    }
-    editor.chain().focus().extendMarkRange('link').setLink({ href: trimmed }).run();
-  };
-
   return createPortal(
     <>
       <button
@@ -215,13 +195,6 @@ export function SceneDescriptionModal({ initialHtml, onClose, onSave }: SceneDes
               >
                 <ToolbarIcon path="M2 17h2v.5H3v1h1v.5H2v1h3v-4H2v1zm1-9h1V4H2v1h1v3zm-1 3h1.8L2 13.1V14h3v-1H3.2L5 10.9V10H2v1zm5-6v2h14V5H7zm0 14h14v-2H7v2zm0-6h14v-2H7v2z" />
               </ToolButton>
-              <ToolButton
-                title={t('scene.descriptionLink')}
-                disabled={!toolbarState.canLink}
-                onClick={setLink}
-              >
-                <ToolbarIcon path="M3.9 12a5 5 0 0 1 5-5h4v2h-4a3 3 0 1 0 0 6h4v2h-4a5 5 0 0 1-5-5zm7-1h6v2h-6v-2zm5-4h-4v2h4a3 3 0 1 1 0 6h-4v2h4a5 5 0 0 0 0-10z" />
-              </ToolButton>
             </div>
           </div>
           <div className={modalStyles.editorContent}>
diff --git a/app/renderer/editor/i18n/editorMessages.ts b/app/renderer/editor/i18n/editorMessages.ts
index f4c2054..603c622 100644
--- a/app/renderer/editor/i18n/editorMessages.ts
+++ b/app/renderer/editor/i18n/editorMessages.ts
@@ -306,6 +306,8 @@ export const EDITOR_MESSAGES: Record<EditorLocale, Record<string, string>> = {
     'picker.title': 'Проекты',
     'picker.newPlaceholder': 'Название нового проекта…',
     'picker.create': 'Создать проект',
+    'picker.search': 'Поиск кампаний…',
+    'picker.searchEmpty': 'Ничего не найдено.',
     'picker.existing': 'СУЩЕСТВУЮЩИЕ',
     'picker.lockedHint':
       'Открытие и создание — после активации лицензии. Список показывает файлы в папке приложения.',
@@ -709,6 +711,8 @@ export const EDITOR_MESSAGES: Record<EditorLocale, Record<string, string>> = {
     'picker.title': 'Projects',
     'picker.newPlaceholder': 'New project name…',
     'picker.create': 'Create project',
+    'picker.search': 'Search campaigns…',
+    'picker.searchEmpty': 'No matches.',
     'picker.existing': 'EXISTING',
     'picker.lockedHint':
       'Opening and creating projects require an active license. The list still shows files in the app folder.',